refactor(flags): migrate icon discovery runtime flag (#27609)

packages/opencode/test/effect/runtime-flags.test.ts

@@ -39,6 +39,7 @@ describe("RuntimeFlags", () => {
       expect(flags.experimentalPlanMode).toBe(true)
       expect(flags.experimentalEventSystem).toBe(true)
       expect(flags.experimentalWorkspaces).toBe(true)
+      expect(flags.experimentalIconDiscovery).toBe(true)
       expect(flags.client).toBe("desktop")
     }),
   )
@@ -53,6 +54,7 @@ describe("RuntimeFlags", () => {
       expect(flags.disableDefaultPlugins).toBe(true)
       expect(flags.disableClaudeCodeSkills).toBe(false)
       expect(flags.enableExa).toBe(false)
+      expect(flags.experimentalIconDiscovery).toBe(false)
       expect(flags.experimentalOxfmt).toBe(false)
       expect(flags.bashDefaultTimeoutMs).toBe(1_000)
       expect(flags.enableExperimentalModels).toBe(false)
@@ -60,6 +62,32 @@ describe("RuntimeFlags", () => {
     }),
   )
 
+  it.effect("experimentalIconDiscovery defaults to false", () =>
+    Effect.gen(function* () {
+      const flags = yield* readFlags.pipe(Effect.provide(fromConfig({})))
+
+      expect(flags.experimentalIconDiscovery).toBe(false)
+    }),
+  )
+
+  it.effect("experimentalIconDiscovery reads OPENCODE_EXPERIMENTAL_ICON_DISCOVERY", () =>
+    Effect.gen(function* () {
+      const flags = yield* readFlags.pipe(
+        Effect.provide(fromConfig({ OPENCODE_EXPERIMENTAL_ICON_DISCOVERY: "true" })),
+      )
+
+      expect(flags.experimentalIconDiscovery).toBe(true)
+    }),
+  )
+
+  it.effect("experimentalIconDiscovery inherits OPENCODE_EXPERIMENTAL", () =>
+    Effect.gen(function* () {
+      const flags = yield* readFlags.pipe(Effect.provide(fromConfig({ OPENCODE_EXPERIMENTAL: "true" })))
+
+      expect(flags.experimentalIconDiscovery).toBe(true)
+    }),
+  )
+
   it.effect("experimentalOxfmt defaults to false", () =>
     Effect.gen(function* () {
       const flags = yield* readFlags.pipe(Effect.provide(fromConfig({})))
@@ -147,6 +175,7 @@ describe("RuntimeFlags", () => {
       expect(flags.disableDefaultPlugins).toBe(false)
       expect(flags.disableClaudeCodeSkills).toBe(false)
       expect(flags.enableExa).toBe(false)
+      expect(flags.experimentalIconDiscovery).toBe(false)
       expect(flags.experimentalOxfmt).toBe(false)
       expect(flags.bashDefaultTimeoutMs).toBeUndefined()
       expect(flags.client).toBe("cli")

packages/opencode/test/project/project.test.ts

@@ -13,6 +13,7 @@ import { NodePath } from "@effect/platform-node"
 import { AppFileSystem } from "@opencode-ai/core/filesystem"
 import { CrossSpawnSpawner } from "@opencode-ai/core/cross-spawn-spawner"
 import { testEffect } from "../lib/effect"
+import { RuntimeFlags } from "@/effect/runtime-flags"
 
 void Log.init({ print: false })
 
@@ -69,12 +70,39 @@ function projectLayerWithFailure(failArg: string) {
     Layer.provide(Bus.defaultLayer),
     Layer.provide(AppFileSystem.defaultLayer),
     Layer.provide(NodePath.layer),
+    Layer.provide(RuntimeFlags.defaultLayer),
+  )
+}
+
+function projectLayerWithRuntimeFlags(flags: Parameters<typeof RuntimeFlags.layer>[0]) {
+  return Project.layer.pipe(
+    Layer.provide(Bus.defaultLayer),
+    Layer.provide(AppFileSystem.defaultLayer),
+    Layer.provide(NodePath.layer),
+    Layer.provide(RuntimeFlags.layer(flags)),
   )
 }
 
 const failureIt = (failArg: string) =>
   testEffect(Layer.mergeAll(projectLayerWithFailure(failArg), CrossSpawnSpawner.defaultLayer))
 
+const iconDiscoveryIt = testEffect(
+  Layer.provideMerge(
+    projectLayerWithRuntimeFlags({ experimentalIconDiscovery: true }),
+    CrossSpawnSpawner.defaultLayer,
+  ),
+)
+
+function waitForProjectIcon(id: ProjectID, attempts = 50): Effect.Effect<Project.Info> {
+  return Effect.gen(function* () {
+    const project = Project.get(id)
+    if (project?.icon?.url) return project
+    if (attempts <= 0) throw new Error(`Project icon was not discovered: ${id}`)
+    yield* Effect.sleep("10 millis")
+    return yield* waitForProjectIcon(id, attempts - 1)
+  })
+}
+
 describe("Project.fromDirectory", () => {
   it.live("should handle git repository with no commits", () =>
     Effect.gen(function* () {
@@ -284,6 +312,20 @@ describe("Project.fromDirectory with worktrees", () => {
 })
 
 describe("Project.discover", () => {
+  iconDiscoveryIt.live("discovers favicon from fromDirectory when enabled", () =>
+    Effect.gen(function* () {
+      const tmp = yield* tmpdirScoped({ git: true })
+      const pngData = Buffer.from([0x89, 0x50, 0x4e, 0x47, 0x0d, 0x0a, 0x1a, 0x0a])
+      yield* Effect.promise(() => Bun.write(path.join(tmp, "favicon.png"), pngData))
+
+      const { project } = yield* run((svc) => svc.fromDirectory(tmp))
+      const updated = yield* waitForProjectIcon(project.id)
+
+      expect(updated.icon?.url).toStartWith("data:")
+      expect(updated.icon?.url).toContain("base64")
+    }),
+  )
+
   it.live("should discover favicon.png in root", () =>
     Effect.gen(function* () {
       const tmp = yield* tmpdirScoped({ git: true })