fix(desktop-electron): match dev dock icon inset on macOS (#19429)
This commit is contained in:
@@ -9,3 +9,6 @@ Here's the process I've been using to create icons:
|
|||||||
|
|
||||||
The Image2Icon step is necessary as the `icon.icns` generated by `app-icon.png` does not apply the shadow/padding expected by macOS,
|
The Image2Icon step is necessary as the `icon.icns` generated by `app-icon.png` does not apply the shadow/padding expected by macOS,
|
||||||
so app icons appear larger than expected.
|
so app icons appear larger than expected.
|
||||||
|
|
||||||
|
For unpackaged Electron on macOS, `app.dock.setIcon()` should use a PNG. Keep `dock.png` in each channel folder synced with the
|
||||||
|
extracted `icon_128x128@2x.png` from that channel's `icon.icns` so the dev Dock icon matches the packaged app inset.
|
||||||
|
|||||||
Binary file not shown.
|
After Width: | Height: | Size: 33 KiB |
Binary file not shown.
|
After Width: | Height: | Size: 49 KiB |
Binary file not shown.
|
After Width: | Height: | Size: 38 KiB |
@@ -50,7 +50,8 @@ export function setTitlebar(win: BrowserWindow, theme: Partial<TitlebarTheme> =
|
|||||||
|
|
||||||
export function setDockIcon() {
|
export function setDockIcon() {
|
||||||
if (process.platform !== "darwin") return
|
if (process.platform !== "darwin") return
|
||||||
app.dock?.setIcon(nativeImage.createFromPath(join(iconsDir(), "128x128@2x.png")))
|
const icon = nativeImage.createFromPath(join(iconsDir(), "dock.png"))
|
||||||
|
if (!icon.isEmpty()) app.dock?.setIcon(icon)
|
||||||
}
|
}
|
||||||
|
|
||||||
export function createMainWindow(globals: Globals) {
|
export function createMainWindow(globals: Globals) {
|
||||||
|
|||||||
Reference in New Issue
Block a user