feat: enable type-aware no-base-to-string rule, fix 56 violations (#22750)

packages/opencode/src/effect/logger.ts

@@ -15,7 +15,9 @@ const clean = (input?: Fields): Fields =>
   Object.fromEntries(Object.entries(input ?? {}).filter((entry) => entry[1] !== undefined && entry[1] !== null))
 
 const text = (input: unknown): string => {
+  // oxlint-disable-next-line no-base-to-string
   if (Array.isArray(input)) return input.map((item) => String(item)).join(" ")
+  // oxlint-disable-next-line no-base-to-string
   return input === undefined ? "" : String(input)
 }
 

packages/opencode/src/plugin/github-copilot/copilot.ts

@@ -93,7 +93,7 @@ export async function CopilotAuthPlugin(input: PluginInput): Promise<Hooks> {
             const info = await getAuth()
             if (info.type !== "oauth") return fetch(request, init)
 
-            const url = request instanceof URL ? request.href : request.toString()
+            const url = request instanceof URL ? request.href : typeof request === "string" ? request : request.url
             const { isVision, isAgent } = iife(() => {
               try {
                 const body = typeof init?.body === "string" ? JSON.parse(init.body) : init?.body

packages/opencode/src/provider/transform.ts

@@ -274,7 +274,7 @@ export namespace ProviderTransform {
 
         // Check for empty base64 image data
         if (part.type === "image") {
-          const imageStr = part.image.toString()
+          const imageStr = String(part.image)
           if (imageStr.startsWith("data:")) {
             const match = imageStr.match(/^data:([^;]+);base64,(.*)$/)
             if (match && (!match[2] || match[2].length === 0)) {
@@ -286,7 +286,7 @@ export namespace ProviderTransform {
           }
         }
 
-        const mime = part.type === "image" ? part.image.toString().split(";")[0].replace("data:", "") : part.mediaType
+        const mime = part.type === "image" ? String(part.image).split(";")[0].replace("data:", "") : part.mediaType
         const filename = part.type === "file" ? part.filename : undefined
         const modality = mimeToModality(mime)
         if (!modality) return part

packages/opencode/src/pty/service.ts

@@ -346,7 +346,7 @@ export const layer = Layer.effect(
 
       return {
         onMessage: (message: string | ArrayBuffer) => {
-          session.process.write(String(message))
+          session.process.write(typeof message === "string" ? message : new TextDecoder().decode(message))
         },
         onClose: () => {
           log.info("client disconnected from session", { id })

packages/opencode/src/snapshot/snapshot.ts

@@ -116,7 +116,7 @@ export const layer: Layer.Layer<
             Effect.succeed({
               code: ChildProcessSpawner.ExitCode(1),
               text: "",
-              stderr: String(err),
+              stderr: err instanceof Error ? err.message : String(err),
             }),
           ),
         )

packages/opencode/src/tool/apply_patch.ts

@@ -145,7 +145,15 @@ export const ApplyPatchTool = Tool.define(
           case "delete": {
             const contentToDelete = yield* afs
               .readFileString(filePath)
-              .pipe(Effect.catch((error) => Effect.fail(new Error(`apply_patch verification failed: ${error}`))))
+              .pipe(
+                Effect.catch((error) =>
+                  Effect.fail(
+                    new Error(
+                      `apply_patch verification failed: ${error instanceof Error ? error.message : String(error)}`,
+                    ),
+                  ),
+                ),
+              )
             const deleteDiff = trimDiff(createTwoFilesPatch(filePath, filePath, contentToDelete, ""))
 
             const deletions = contentToDelete.split("\n").length

packages/opencode/src/util/error.ts

@@ -60,6 +60,7 @@ export function errorData(error: unknown) {
       acc[key] = value
       return acc
     }
+    // oxlint-disable-next-line no-base-to-string -- intentional coercion of arbitrary error properties
     acc[key] = value instanceof Error ? value.message : String(value)
     return acc
   }, {})

packages/opencode/src/v2/session-entry.ts

@@ -202,6 +202,7 @@ export namespace SessionEntry {
         case "tool.input.delta": {
           if (!pendingAssistant) break
           const match = pendingAssistant.content.findLast((x) => x.type === "tool")
+          // oxlint-disable-next-line no-base-to-string -- event.delta is a Schema.String (runtime string)
           if (match) match.state.input += event.delta
           break
         }