lmin/zmo-cli
1
0
Fork 0
Code Issues Pull Requests Actions 6 Packages Projects Releases Wiki Activity

feat: enable type-aware no-floating-promises rule, fix all 177 violations (#22741)

Browse Source
This commit is contained in:
Kit Langton
2026-04-15 23:27:32 -04:00
committed by GitHub
parent 343a564183
commit 80f1f1b5b8
103 changed files with 212 additions and 187 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
packages/opencode/src/acp/agent.ts
View File

@@ -242,7 +242,7 @@ export namespace ACP {
const newContent = getNewContent(content, diff)
if (newContent) {
this.connection.writeTextFile({
void this.connection.writeTextFile({
sessionId: session.id,
path: filepath,
content: newContent,
@@ -1253,7 +1253,7 @@ export namespace ACP {
)
setTimeout(() => {
this.connection.sessionUpdate({
void this.connection.sessionUpdate({
sessionId,
update: {
sessionUpdate: "available_commands_update",

6
packages/opencode/src/cli/cmd/tui/app.tsx
View File

@@ -350,7 +350,7 @@ function App(props: { onSnapshot?: () => Promise<string[]> }) {
if (match) {
continued = true
if (args.fork) {
sdk.client.session.fork({ sessionID: match }).then((result) => {
void sdk.client.session.fork({ sessionID: match }).then((result) => {
if (result.data?.id) {
route.navigate({ type: "session", sessionID: result.data.id })
} else {
@@ -370,7 +370,7 @@ function App(props: { onSnapshot?: () => Promise<string[]> }) {
createEffect(() => {
if (forked || sync.status !== "complete" || !args.sessionID || !args.fork) return
forked = true
sdk.client.session.fork({ sessionID: args.sessionID }).then((result) => {
void sdk.client.session.fork({ sessionID: args.sessionID }).then((result) => {
if (result.data?.id) {
route.navigate({ type: "session", sessionID: result.data.id })
} else {
@@ -818,7 +818,7 @@ function App(props: { onSnapshot?: () => Promise<string[]> }) {
`Successfully updated to OpenCode v${result.data.version}. Please restart the application.`,
)
exit()
void exit()
})
const plugin = createMemo(() => {

2
packages/opencode/src/cli/cmd/tui/component/dialog-session-list.tsx
View File

@@ -145,7 +145,7 @@ export function DialogSessionList() {
title: "delete",
onTrigger: async (option) => {
if (toDelete() === option.value) {
sdk.client.session.delete({
void sdk.client.session.delete({
sessionID: option.value,
})
setToDelete(undefined)

2
packages/opencode/src/cli/cmd/tui/component/dialog-session-rename.tsx
View File

@@ -19,7 +19,7 @@ export function DialogSessionRename(props: DialogSessionRenameProps) {
title="Rename Session"
value={session()?.title}
onConfirm={(value) => {
sdk.client.session.update({
void sdk.client.session.update({
sessionID: props.session,
title: value,
})

4
packages/opencode/src/cli/cmd/tui/component/error-component.tsx
View File

@@ -26,7 +26,7 @@ export function ErrorComponent(props: {
useKeyboard((evt) => {
if (evt.ctrl && evt.name === "c") {
handleExit()
void handleExit()
}
})
const [copied, setCopied] = createSignal(false)
@@ -56,7 +56,7 @@ export function ErrorComponent(props: {
issueURL.searchParams.set("opencode-version", Installation.VERSION)
const copyIssueURL = () => {
Clipboard.copy(issueURL.toString()).then(() => {
void Clipboard.copy(issueURL.toString()).then(() => {
setCopied(true)
})
}

16
packages/opencode/src/cli/cmd/tui/component/prompt/index.tsx
View File

@@ -235,7 +235,7 @@ export function Prompt(props: PromptProps) {
hidden: true,
onSelect: (dialog) => {
if (!input.focused) return
submit()
void submit()
dialog.clear()
},
},
@@ -280,7 +280,7 @@ export function Prompt(props: PromptProps) {
}, 5000)
if (store.interrupt >= 2) {
sdk.client.session.abort({
void sdk.client.session.abort({
sessionID: props.sessionID,
})
setStore("interrupt", 0)
@@ -429,7 +429,7 @@ export function Prompt(props: PromptProps) {
setStore("extmarkToPartIndex", new Map())
},
submit() {
submit()
void submit()
},
}
@@ -604,12 +604,12 @@ export function Prompt(props: PromptProps) {
if (!store.prompt.input) return
const trimmed = store.prompt.input.trim()
if (trimmed === "exit" || trimmed === "quit" || trimmed === ":q") {
exit()
void exit()
return
}
const selectedModel = local.model.current()
if (!selectedModel) {
promptModelWarning()
void promptModelWarning()
return
}
@@ -660,7 +660,7 @@ export function Prompt(props: PromptProps) {
const variant = local.model.variant.current()
if (store.mode === "shell") {
sdk.client.session.shell({
void sdk.client.session.shell({
sessionID,
agent: local.agent.current().name,
model: {
@@ -685,7 +685,7 @@ export function Prompt(props: PromptProps) {
const restOfInput = firstLineEnd === -1 ? "" : inputText.slice(firstLineEnd + 1)
const args = firstLineArgs.join(" ") + (restOfInput ? "\n" + restOfInput : "")
sdk.client.session.command({
void sdk.client.session.command({
sessionID,
command: command.slice(1),
arguments: args,
@@ -1208,7 +1208,7 @@ export function Prompt(props: PromptProps) {
const r = retry()
if (!r) return
if (isTruncated()) {
DialogAlert.show(dialog, "Retry Error", r.message)
void DialogAlert.show(dialog, "Retry Error", r.message)
}
}

2
packages/opencode/src/cli/cmd/tui/context/kv.tsx
View File

@@ -44,7 +44,7 @@ export const { use: useKV, provider: KVProvider } = createSimpleContext({
},
set(key: string, value: any) {
setStore(key, value)
Filesystem.writeJson(filePath, store)
void Filesystem.writeJson(filePath, store)
},
}
return result

2
packages/opencode/src/cli/cmd/tui/context/local.tsx
View File

@@ -131,7 +131,7 @@ export const { use: useLocal, provider: LocalProvider } = createSimpleContext({
return
}
state.pending = false
Filesystem.writeJson(filePath, {
void Filesystem.writeJson(filePath, {
recent: modelStore.recent,
favorite: modelStore.favorite,
variant: modelStore.variant,

6
packages/opencode/src/cli/cmd/tui/context/sync.tsx
View File

@@ -111,7 +111,7 @@ export const { use: useSync, provider: SyncProvider } = createSimpleContext({
event.subscribe((event) => {
switch (event.type) {
case "server.instance.disposed":
bootstrap()
void bootstrap()
break
case "permission.replied": {
const requests = store.permission[event.properties.sessionID]
@@ -336,7 +336,7 @@ export const { use: useSync, provider: SyncProvider } = createSimpleContext({
case "lsp.updated": {
const workspace = project.workspace.current()
sdk.client.lsp.status({ workspace }).then((x) => setStore("lsp", x.data ?? []))
void sdk.client.lsp.status({ workspace }).then((x) => setStore("lsp", x.data ?? []))
break
}
@@ -415,7 +415,7 @@ export const { use: useSync, provider: SyncProvider } = createSimpleContext({
.then(() => {
if (store.status !== "complete") setStore("status", "partial")
// non-blocking
Promise.all([
void Promise.all([
...(args.continue ? [] : [sessionListPromise.then((sessions) => setStore("session", reconcile(sessions)))]),
consoleStatePromise.then((consoleState) => setStore("console_state", reconcile(consoleState))),
sdk.client.command.list({ workspace }).then((x) => setStore("command", reconcile(x.data ?? []))),

4
packages/opencode/src/cli/cmd/tui/context/theme.tsx
View File

@@ -329,7 +329,7 @@ export const { use: useTheme, provider: ThemeProvider } = createSimpleContext({
})
function init() {
Promise.allSettled([
void Promise.allSettled([
resolveSystemTheme(store.mode),
getCustomThemes()
.then((custom) => {
@@ -377,7 +377,7 @@ export const { use: useTheme, provider: ThemeProvider } = createSimpleContext({
if (store.mode === mode) return
setStore("mode", mode)
renderer.clearPaletteCache()
resolveSystemTheme(mode)
void resolveSystemTheme(mode)
}
function pin(mode: "dark" | "light" = store.mode) {

4
packages/opencode/src/cli/cmd/tui/feature-plugins/system/plugins.tsx
View File

@@ -78,7 +78,7 @@ function Install(props: { api: TuiPluginApi }) {
}
setBusy(true)
props.api.plugins
void props.api.plugins
.install(mod, { global: global() })
.then((out) => {
if (!out.ok) {
@@ -188,7 +188,7 @@ function View(props: { api: TuiPluginApi }) {
if (!item) return
setLock(true)
const task = item.active ? props.api.plugins.deactivate(x) : props.api.plugins.activate(x)
task
void task
.then((ok) => {
if (!ok) {
props.api.ui.toast({

2
packages/opencode/src/cli/cmd/tui/routes/session/dialog-message.tsx
View File

@@ -29,7 +29,7 @@ export function DialogMessage(props: {
const msg = message()
if (!msg) return
sdk.client.session.revert({
void sdk.client.session.revert({
sessionID: props.sessionID,
messageID: msg.id,
})

14
packages/opencode/src/cli/cmd/tui/routes/session/index.tsx
View File

@@ -241,7 +241,7 @@ export function Session() {
if (kv.get(GO_UPSELL_DONT_SHOW)) return
DialogGoUpsell.show(dialog).then((dontShowAgain) => {
void DialogGoUpsell.show(dialog).then((dontShowAgain) => {
if (dontShowAgain) kv.set(GO_UPSELL_DONT_SHOW, true)
kv.set(GO_UPSELL_LAST_SEEN_AT, Date.now())
})
@@ -272,7 +272,7 @@ export function Session() {
useKeyboard((evt) => {
if (!session()?.parentID) return
if (keybind.match("app_exit", evt)) {
exit()
void exit()
}
})
@@ -483,7 +483,7 @@ export function Session() {
})
return
}
sdk.client.session.summarize({
void sdk.client.session.summarize({
sessionID: route.sessionID,
modelID: selectedModel.modelID,
providerID: selectedModel.providerID,
@@ -529,7 +529,7 @@ export function Session() {
const revert = session()?.revert?.messageID
const message = messages().findLast((x) => (!revert || x.id < revert) && x.role === "user")
if (!message) return
sdk.client.session
void sdk.client.session
.revert({
sessionID: route.sessionID,
messageID: message.id,
@@ -568,13 +568,13 @@ export function Session() {
if (!messageID) return
const message = messages().find((x) => x.role === "user" && x.id > messageID)
if (!message) {
sdk.client.session.unrevert({
void sdk.client.session.unrevert({
sessionID: route.sessionID,
})
prompt?.set({ input: "", parts: [] })
return
}
sdk.client.session.revert({
void sdk.client.session.revert({
sessionID: route.sessionID,
messageID: message.id,
})
@@ -1966,7 +1966,7 @@ function Task(props: ToolProps<typeof TaskTool>) {
onMount(() => {
if (props.metadata.sessionId && !sync.data.message[props.metadata.sessionId]?.length)
sync.session.sync(props.metadata.sessionId)
void sync.session.sync(props.metadata.sessionId)
})
const messages = createMemo(() => sync.data.message[props.metadata.sessionId ?? ""] ?? [])

8
packages/opencode/src/cli/cmd/tui/routes/session/permission.tsx
View File

@@ -184,7 +184,7 @@ export function PermissionPrompt(props: { request: PermissionRequest }) {
onSelect={(option) => {
setStore("stage", "permission")
if (option === "cancel") return
sdk.client.permission.reply({
void sdk.client.permission.reply({
reply: "always",
requestID: props.request.id,
})
@@ -194,7 +194,7 @@ export function PermissionPrompt(props: { request: PermissionRequest }) {
<Match when={store.stage === "reject"}>
<RejectPrompt
onConfirm={(message) => {
sdk.client.permission.reply({
void sdk.client.permission.reply({
reply: "reject",
requestID: props.request.id,
message: message || undefined,
@@ -447,13 +447,13 @@ export function PermissionPrompt(props: { request: PermissionRequest }) {
setStore("stage", "reject")
return
}
sdk.client.permission.reply({
void sdk.client.permission.reply({
reply: "reject",
requestID: props.request.id,
})
return
}
sdk.client.permission.reply({
void sdk.client.permission.reply({
reply: "once",
requestID: props.request.id,
})

6
packages/opencode/src/cli/cmd/tui/routes/session/question.tsx
View File

@@ -45,14 +45,14 @@ export function QuestionPrompt(props: { request: QuestionRequest }) {
function submit() {
const answers = questions().map((_, i) => store.answers[i] ?? [])
sdk.client.question.reply({
void sdk.client.question.reply({
requestID: props.request.id,
answers,
})
}
function reject() {
sdk.client.question.reject({
void sdk.client.question.reject({
requestID: props.request.id,
})
}
@@ -67,7 +67,7 @@ export function QuestionPrompt(props: { request: QuestionRequest }) {
setStore("custom", inputs)
}
if (single()) {
sdk.client.question.reply({
void sdk.client.question.reply({
requestID: props.request.id,
answers: [[answer]],
})

6
packages/opencode/src/config/config.ts
View File

@@ -171,7 +171,7 @@ async function loadCommand(dir: string) {
? err.data.message
: `Failed to parse command ${item}`
const { Session } = await import("@/session")
Bus.publish(Session.Event.Error, { error: new NamedError.Unknown({ message }).toObject() })
void Bus.publish(Session.Event.Error, { error: new NamedError.Unknown({ message }).toObject() })
log.error("failed to load command", { command: item, err })
return undefined
})
@@ -210,7 +210,7 @@ async function loadAgent(dir: string) {
? err.data.message
: `Failed to parse agent ${item}`
const { Session } = await import("@/session")
Bus.publish(Session.Event.Error, { error: new NamedError.Unknown({ message }).toObject() })
void Bus.publish(Session.Event.Error, { error: new NamedError.Unknown({ message }).toObject() })
log.error("failed to load agent", { agent: item, err })
return undefined
})
@@ -248,7 +248,7 @@ async function loadMode(dir: string) {
? err.data.message
: `Failed to parse mode ${item}`
const { Session } = await import("@/session")
Bus.publish(Session.Event.Error, { error: new NamedError.Unknown({ message }).toObject() })
void Bus.publish(Session.Event.Error, { error: new NamedError.Unknown({ message }).toObject() })
log.error("failed to load mode", { mode: item, err })
return undefined
})

6
packages/opencode/src/control-plane/workspace.ts
View File

@@ -114,7 +114,7 @@ export namespace Workspace {
await adaptor.create(config)
startSync(info)
void startSync(info)
await waitEvent({
timeout: TIMEOUT,
@@ -294,7 +294,7 @@ export namespace Workspace {
)
const spaces = rows.map(fromRow).sort((a, b) => a.id.localeCompare(b.id))
for (const space of spaces) startSync(space)
for (const space of spaces) void startSync(space)
return spaces
}
@@ -307,7 +307,7 @@ export namespace Workspace {
export const get = fn(WorkspaceID.zod, async (id) => {
const space = lookup(id)
if (!space) return
startSync(space)
void startSync(space)
return space
})

6
packages/opencode/src/file/watcher.ts
View File

@@ -98,9 +98,9 @@ export namespace FileWatcher {
const cb: ParcelWatcher.SubscribeCallback = Instance.bind((err, evts) => {
if (err) return
for (const evt of evts) {
if (evt.type === "create") Bus.publish(Event.Updated, { file: evt.path, event: "add" })
if (evt.type === "update") Bus.publish(Event.Updated, { file: evt.path, event: "change" })
if (evt.type === "delete") Bus.publish(Event.Updated, { file: evt.path, event: "unlink" })
if (evt.type === "create") void Bus.publish(Event.Updated, { file: evt.path, event: "add" })
if (evt.type === "update") void Bus.publish(Event.Updated, { file: evt.path, event: "change" })
if (evt.type === "delete") void Bus.publish(Event.Updated, { file: evt.path, event: "unlink" })
}
})

2
packages/opencode/src/lsp/client.ts
View File

@@ -59,7 +59,7 @@ export namespace LSPClient {
const exists = diagnostics.has(filePath)
diagnostics.set(filePath, params.diagnostics)
if (!exists && input.serverID === "typescript") return
Bus.publish(Event.Diagnostics, { path: filePath, serverID: input.serverID })
void Bus.publish(Event.Diagnostics, { path: filePath, serverID: input.serverID })
})
connection.onRequest("window/workDoneProgress/create", (params) => {
l.info("window/workDoneProgress/create", params)

4
packages/opencode/src/lsp/index.ts
View File

@@ -293,7 +293,7 @@ export namespace LSP {
const task = schedule(server, root, root + server.id)
s.spawning.set(root + server.id, task)
task.finally(() => {
void task.finally(() => {
if (s.spawning.get(root + server.id) === task) {
s.spawning.delete(root + server.id)
}
@@ -303,7 +303,7 @@ export namespace LSP {
if (!client) continue
result.push(client)
Bus.publish(Event.Updated, {})
void Bus.publish(Event.Updated, {})
}
return result

2
packages/opencode/src/plugin/plugin.ts
View File

@@ -245,7 +245,7 @@ export const layer = Layer.effect(
Stream.runForEach((input) =>
Effect.sync(() => {
for (const hook of hooks) {
hook["event"]?.({ event: input as any })
void hook["event"]?.({ event: input as any })
}
}),
),

2
packages/opencode/src/provider/models.ts
View File

@@ -172,7 +172,7 @@ export namespace ModelsDev {
}
if (!Flag.OPENCODE_DISABLE_MODELS_FETCH && !process.argv.includes("--get-yargs-completions")) {
ModelsDev.refresh()
void ModelsDev.refresh()
setInterval(
async () => {
await ModelsDev.refresh()

18
packages/opencode/src/server/instance/session.ts
View File

@@ -898,7 +898,7 @@ export const SessionRoutes = lazy(() =>
const msg = await AppRuntime.runPromise(
SessionPrompt.Service.use((svc) => svc.prompt({ ...body, sessionID })),
)
stream.write(JSON.stringify(msg))
void stream.write(JSON.stringify(msg))
})
},
)
@@ -926,13 +926,15 @@ export const SessionRoutes = lazy(() =>
async (c) => {
const sessionID = c.req.valid("param").sessionID
const body = c.req.valid("json")
AppRuntime.runPromise(SessionPrompt.Service.use((svc) => svc.prompt({ ...body, sessionID }))).catch((err) => {
log.error("prompt_async failed", { sessionID, error: err })
Bus.publish(Session.Event.Error, {
sessionID,
error: new NamedError.Unknown({ message: err instanceof Error ? err.message : String(err) }).toObject(),
})
})
void AppRuntime.runPromise(SessionPrompt.Service.use((svc) => svc.prompt({ ...body, sessionID }))).catch(
(err) => {
log.error("prompt_async failed", { sessionID, error: err })
void Bus.publish(Session.Event.Error, {
sessionID,
error: new NamedError.Unknown({ message: err instanceof Error ? err.message : String(err) }).toObject(),
})
},
)
return c.body(null, 204)
},

2
packages/opencode/src/server/proxy.ts
View File

@@ -76,7 +76,7 @@ const app = (upgrade: UpgradeWebSocket) =>
queue.length = 0
}
remote.onmessage = (event) => {
send(ws, event.data)
void send(ws, event.data)
}
remote.onerror = () => {
ws.close(1011, "proxy error")

6
packages/opencode/src/storage/db.ts
View File

@@ -134,7 +134,7 @@ export namespace Database {
if (err instanceof LocalContext.NotFound) {
const effects: (() => void | Promise<void>)[] = []
const result = ctx.provide({ effects, tx: Client() }, () => callback(Client()))
for (const effect of effects) effect()
for (const effect of effects) void effect()
return result
}
throw err
@@ -146,7 +146,7 @@ export namespace Database {
try {
ctx.use().effects.push(bound)
} catch {
bound()
void bound()
}
}
@@ -165,7 +165,7 @@ export namespace Database {
const effects: (() => void | Promise<void>)[] = []
const txCallback = InstanceState.bind((tx: TxOrDb) => ctx.provide({ tx, effects }, () => callback(tx)))
const result = Client().transaction(txCallback, { behavior: options?.behavior })
for (const effect of effects) effect()
for (const effect of effects) void effect()
return result as NotPromise<T>
}
throw err

6
packages/opencode/src/sync/sync-event.ts
View File

@@ -142,11 +142,11 @@ function process<Def extends Definition>(def: Def, event: Event<Def>, options: {
if (options?.publish) {
const result = convertEvent(def.type, event.data)
if (result instanceof Promise) {
result.then((data) => {
ProjectBus.publish({ type: def.type, properties: def.schema }, data)
void result.then((data) => {
void ProjectBus.publish({ type: def.type, properties: def.schema }, data)
})
} else {
ProjectBus.publish({ type: def.type, properties: def.schema }, result)
void ProjectBus.publish({ type: def.type, properties: def.schema }, result)
}
GlobalBus.emit("event", {

2
packages/opencode/src/util/defer.ts
View File

@@ -3,7 +3,7 @@ export function defer<T extends () => void | Promise<void>>(
): T extends () => Promise<void> ? { [Symbol.asyncDispose]: () => Promise<void> } : { [Symbol.dispose]: () => void } {
return {
[Symbol.dispose]() {
fn()
void fn()
},
[Symbol.asyncDispose]() {
return Promise.resolve(fn())

2
packages/opencode/src/util/log.ts
View File

@@ -59,7 +59,7 @@ let write = (msg: any) => {
export async function init(options: Options) {
if (options.level) level = options.level
cleanup(Global.Path.log)
void cleanup(Global.Path.log)
if (options.print) return
logpath = path.join(
Global.Path.log,