Source HTTP API ID path patterns (#26623)

This commit is contained in:
Kit Langton
2026-05-09 22:58:47 -04:00
committed by GitHub
parent 2f11c9f7ed
commit 67b9c9c027
25 changed files with 127 additions and 90 deletions

View File

@@ -61,7 +61,7 @@ const tmpWithFiles = (files: Record<string, string>) =>
function loaded(filepath: string): MessageV2.WithParts[] {
const sessionID = SessionID.make("session-loaded-1")
const messageID = MessageID.make("message-loaded-1")
const messageID = MessageID.make("msg_message-loaded-1")
return [
{
@@ -78,7 +78,7 @@ function loaded(filepath: string): MessageV2.WithParts[] {
},
parts: [
{
id: PartID.make("part-loaded-1"),
id: PartID.make("prt_part-loaded-1"),
messageID,
sessionID,
type: "tool",
@@ -106,7 +106,7 @@ describe("Instruction.resolve", () => {
const system = yield* svc.systemPaths()
expect(system.has(path.join(dir, "AGENTS.md"))).toBe(true)
const results = yield* svc.resolve([], path.join(dir, "src", "file.ts"), MessageID.make("message-test-1"))
const results = yield* svc.resolve([], path.join(dir, "src", "file.ts"), MessageID.make("msg_message-test-1"))
expect(results).toEqual([])
}),
),
@@ -122,7 +122,7 @@ describe("Instruction.resolve", () => {
const results = yield* svc.resolve(
[],
path.join(dir, "subdir", "nested", "file.ts"),
MessageID.make("message-test-2"),
MessageID.make("msg_message-test-2"),
)
expect(results.length).toBe(1)
expect(results[0].filepath).toBe(path.join(dir, "subdir", "AGENTS.md"))
@@ -138,7 +138,7 @@ describe("Instruction.resolve", () => {
const system = yield* svc.systemPaths()
expect(system.has(filepath)).toBe(false)
const results = yield* svc.resolve([], filepath, MessageID.make("message-test-3"))
const results = yield* svc.resolve([], filepath, MessageID.make("msg_message-test-3"))
expect(results).toEqual([])
}),
),
@@ -149,7 +149,7 @@ describe("Instruction.resolve", () => {
Effect.gen(function* () {
const svc = yield* Instruction.Service
const filepath = path.join(dir, "subdir", "nested", "file.ts")
const id = MessageID.make("message-claim-1")
const id = MessageID.make("msg_message-claim-1")
const first = yield* svc.resolve([], filepath, id)
const second = yield* svc.resolve([], filepath, id)
@@ -166,7 +166,7 @@ describe("Instruction.resolve", () => {
Effect.gen(function* () {
const svc = yield* Instruction.Service
const filepath = path.join(dir, "subdir", "nested", "file.ts")
const id = MessageID.make("message-claim-2")
const id = MessageID.make("msg_message-claim-2")
const first = yield* svc.resolve([], filepath, id)
yield* svc.clear(id)
@@ -185,7 +185,7 @@ describe("Instruction.resolve", () => {
const svc = yield* Instruction.Service
const agents = path.join(dir, "subdir", "AGENTS.md")
const filepath = path.join(dir, "subdir", "nested", "file.ts")
const id = MessageID.make("message-claim-3")
const id = MessageID.make("msg_message-claim-3")
const results = yield* svc.resolve(loaded(agents), filepath, id)
expect(results).toEqual([])

View File

@@ -354,7 +354,7 @@ describe("session.llm.stream", () => {
} satisfies Agent.Info
const user = {
id: MessageID.make("user-1"),
id: MessageID.make("msg_user-1"),
sessionID,
role: "user",
time: { created: Date.now() },
@@ -438,7 +438,7 @@ describe("session.llm.stream", () => {
permission: [{ permission: "*", pattern: "*", action: "allow" }],
} satisfies Agent.Info
const user = {
id: MessageID.make("user-service-abort"),
id: MessageID.make("msg_user-service-abort"),
sessionID,
role: "user",
time: { created: Date.now() },
@@ -529,7 +529,7 @@ describe("session.llm.stream", () => {
} satisfies Agent.Info
const user = {
id: MessageID.make("user-tools"),
id: MessageID.make("msg_user-tools"),
sessionID,
role: "user",
time: { created: Date.now() },
@@ -644,7 +644,7 @@ describe("session.llm.stream", () => {
} satisfies Agent.Info
const user = {
id: MessageID.make("user-2"),
id: MessageID.make("msg_user-2"),
sessionID,
role: "user",
time: { created: Date.now() },
@@ -759,7 +759,7 @@ describe("session.llm.stream", () => {
} satisfies Agent.Info
const user = {
id: MessageID.make("user-data-url"),
id: MessageID.make("msg_user-data-url"),
sessionID,
role: "user",
time: { created: Date.now() },
@@ -880,7 +880,7 @@ describe("session.llm.stream", () => {
} satisfies Agent.Info
const user = {
id: MessageID.make("user-3"),
id: MessageID.make("msg_user-3"),
sessionID,
role: "user",
time: { created: Date.now() },
@@ -995,7 +995,7 @@ describe("session.llm.stream", () => {
permission: [{ permission: "*", pattern: "*", action: "allow" }],
} satisfies Agent.Info
const user = {
id: MessageID.make("user-anthropic-tools"),
id: MessageID.make("msg_user-anthropic-tools"),
sessionID,
role: "user",
time: { created: Date.now() },
@@ -1239,7 +1239,7 @@ describe("session.llm.stream", () => {
} satisfies Agent.Info
const user = {
id: MessageID.make("user-4"),
id: MessageID.make("msg_user-4"),
sessionID,
role: "user",
time: { created: Date.now() },

View File

@@ -102,9 +102,9 @@ function assistantInfo(
function basePart(messageID: string, id: string) {
return {
id: PartID.make(id),
id: PartID.make(id.startsWith("prt") ? id : `prt_${id}`),
sessionID,
messageID: MessageID.make(messageID),
messageID: MessageID.make(messageID.startsWith("msg") ? messageID : `msg_${messageID}`),
}
}