fix(server): stop exposing named defects (#27471)
This commit is contained in:
@@ -20,9 +20,6 @@ export const errorLayer = HttpRouter.middleware<{ handles: unknown }>()((effect)
|
|||||||
const error = defect.defect
|
const error = defect.defect
|
||||||
log.error("failed", { error, cause: Cause.pretty(cause) })
|
log.error("failed", { error, cause: Cause.pretty(cause) })
|
||||||
|
|
||||||
if (error instanceof NamedError) {
|
|
||||||
return Effect.succeed(HttpServerResponse.jsonUnsafe(error.toObject(), { status: 500 }))
|
|
||||||
}
|
|
||||||
return Effect.succeed(
|
return Effect.succeed(
|
||||||
HttpServerResponse.jsonUnsafe(
|
HttpServerResponse.jsonUnsafe(
|
||||||
new NamedError.Unknown({
|
new NamedError.Unknown({
|
||||||
|
|||||||
@@ -1,4 +1,5 @@
|
|||||||
import { NodeHttpServer, NodeServices } from "@effect/platform-node"
|
import { NodeHttpServer, NodeServices } from "@effect/platform-node"
|
||||||
|
import { NamedError } from "@opencode-ai/core/util/error"
|
||||||
import { describe, expect } from "bun:test"
|
import { describe, expect } from "bun:test"
|
||||||
import { Effect, Layer } from "effect"
|
import { Effect, Layer } from "effect"
|
||||||
import { HttpClient, HttpClientRequest, HttpRouter } from "effect/unstable/http"
|
import { HttpClient, HttpClientRequest, HttpRouter } from "effect/unstable/http"
|
||||||
@@ -29,6 +30,26 @@ describe("HttpApi error middleware", () => {
|
|||||||
}),
|
}),
|
||||||
)
|
)
|
||||||
|
|
||||||
|
it.live("returns a safe body for named defects", () =>
|
||||||
|
Effect.gen(function* () {
|
||||||
|
yield* HttpRouter.add(
|
||||||
|
"GET",
|
||||||
|
"/named",
|
||||||
|
Effect.die(new NamedError.Unknown({ message: "secret named marker" })),
|
||||||
|
).pipe(Layer.provide(errorLayer), HttpRouter.serve, Layer.build)
|
||||||
|
|
||||||
|
const response = yield* HttpClientRequest.get("/named").pipe(HttpClient.execute)
|
||||||
|
const body = yield* response.json
|
||||||
|
|
||||||
|
expect(response.status).toBe(500)
|
||||||
|
expect(body).toEqual({
|
||||||
|
name: "UnknownError",
|
||||||
|
data: { message: "Unexpected server error. Check server logs for details." },
|
||||||
|
})
|
||||||
|
expect(JSON.stringify(body)).not.toContain("secret named marker")
|
||||||
|
}),
|
||||||
|
)
|
||||||
|
|
||||||
it.live("does not map storage not-found defects to 404", () =>
|
it.live("does not map storage not-found defects to 404", () =>
|
||||||
Effect.gen(function* () {
|
Effect.gen(function* () {
|
||||||
yield* HttpRouter.add(
|
yield* HttpRouter.add(
|
||||||
|
|||||||
Reference in New Issue
Block a user